Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PatchPlanning] Implement HasSLSA predicate case + tests #1046

Merged
merged 66 commits into from Jul 14, 2023

Conversation

rmetzman
Copy link
Contributor

Description of the PR

This PR add functionality and test cases to the search fucntion to deal with the HasSLSA predicate (coming from an artifact attached to a package) for the purpose of patchPlanning

  • Handles artifact node types
  • Handles isOccurrence relationships
  • Handles hasSLSA relationships

Based off of pseudocode in Draft PR #1036
Based off of tests in Draft PR #1022

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

Rebecca Metzman added 30 commits June 21, 2023 19:56
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
rmetzman and others added 6 commits July 10, 2023 16:02
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
@rmetzman rmetzman marked this pull request as ready for review July 11, 2023 21:08
pkg/guacanalytics/patchPlanning.go Outdated Show resolved Hide resolved
pkg/guacanalytics/patchPlanning.go Outdated Show resolved Hide resolved
pkg/guacanalytics/patchPlanning.go Outdated Show resolved Hide resolved
Rebecca Metzman added 2 commits July 12, 2023 13:42
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
@rmetzman rmetzman requested a review from lumjjb July 12, 2023 14:50
pkg/guacanalytics/patchPlanning.go Outdated Show resolved Hide resolved
pkg/guacanalytics/patchPlanning.go Outdated Show resolved Hide resolved
pkg/guacanalytics/patchPlanning.go Outdated Show resolved Hide resolved
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
@rmetzman rmetzman requested a review from lumjjb July 12, 2023 17:42
Rebecca Metzman added 5 commits July 12, 2023 19:36
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
pkg/guacanalytics/patchPlanning.go Outdated Show resolved Hide resolved
pkg/guacanalytics/patchPlanning.go Outdated Show resolved Hide resolved
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
@rmetzman rmetzman requested a review from lumjjb July 13, 2023 14:28
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
@lumjjb lumjjb requested a review from pxp928 July 14, 2023 13:47
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I am confused by what the SearchDependenciesFromStartNode is trying to return.

pkg/guacanalytics/patchPlanning.go Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit 3cc7cde into guacsec:main Jul 14, 2023
8 checks passed
@rmetzman rmetzman deleted the implementSLSA3 branch July 26, 2023 14:19
@rmetzman rmetzman changed the title Implement HasSLSA predicate case + tests (patchPlanning search method) [PatchPlanning] Implement HasSLSA predicate case + tests Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants