-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PatchPlanning] Implement HasSLSA predicate case + tests #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
lumjjb
reviewed
Jul 11, 2023
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
lumjjb
reviewed
Jul 12, 2023
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
lumjjb
reviewed
Jul 13, 2023
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
pxp928
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I am confused by what the SearchDependenciesFromStartNode
is trying to return.
lumjjb
approved these changes
Jul 14, 2023
rmetzman
changed the title
Implement HasSLSA predicate case + tests (patchPlanning search method)
[PatchPlanning] Implement HasSLSA predicate case + tests
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the PR
This PR add functionality and test cases to the search fucntion to deal with the HasSLSA predicate (coming from an artifact attached to a package) for the purpose of patchPlanning
Based off of pseudocode in Draft PR #1036
Based off of tests in Draft PR #1022
PR Checklist
-s
flag togit commit
.make generate
has been runcollectsub
protobuf has been changed,make proto
has been run