Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup arango backend, add ingestion of builder, add support for source ingestion for Occurrences, return IDs during ingestion and query #1048

Merged
merged 4 commits into from Jul 12, 2023
Merged

cleanup arango backend, add ingestion of builder, add support for source ingestion for Occurrences, return IDs during ingestion and query #1048

merged 4 commits into from Jul 12, 2023

Conversation

pxp928
Copy link
Collaborator

@pxp928 pxp928 commented Jul 11, 2023

Description of the PR

  • cleanup arango backend to remove code duplication
  • add ingestion and query of builder (including bulk)
  • add support for source ingestion for Occurrences
  • return IDs during ingestion and query

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@pxp928
add ingest builder
3835f16 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
add ingest and query builder for arango
64f2cac 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
reorg and cleanup code
a86bde8 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
add constants for collections
862fab4 
Signed-off-by: pxp928 <parth.psu@gmail.com>
lumjjb
lumjjb approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kodiakhq kodiakhq bot merged commit 2b9306d into guacsec:main Jul 12, 2023
8 checks passed
@pxp928 pxp928 deleted the feature/arango-builder branch July 12, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@lumjjb lumjjb lumjjb approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pxp928 @mihaimaruseac @lumjjb