Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PointOfContact predicate ingest #1075

Merged
merged 6 commits into from Jul 20, 2023
Merged

Add PointOfContact predicate ingest #1075

merged 6 commits into from Jul 20, 2023

Conversation

rmetzman
Copy link
Contributor

Description of the PR

Add PointOfContact predicate ingest to assembler

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

real first
4a3f82e 
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
chaning other files
5c411ad 
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jul 19, 2023
Rebecca Metzman added 2 commits July 19, 2023 21:59
chaning typo
647ee60 
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
chaning typo
3b39484 
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
lumjjb
lumjjb approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for adding this and integrating it with the rest of the assembler plumbing!

pkg/assembler/clients/helpers/assembler.go Show resolved Hide resolved
pxp928
pxp928 approved these changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Rebecca Metzman added 2 commits July 20, 2023 15:24
chaning isDep typo
c13513e 
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
typo
92f30e4 
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
@rmetzman rmetzman marked this pull request as ready for review July 20, 2023 15:55
@kodiakhq kodiakhq bot merged commit 778091b into guacsec:main Jul 20, 2023
9 checks passed
@rmetzman rmetzman changed the title Add PointOfContact predicate ingest [PatchPlanning] Add PointOfContact predicate ingest Aug 8, 2023
@rmetzman rmetzman changed the title [PatchPlanning] Add PointOfContact predicate ingest Add PointOfContact predicate ingest Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumjjb lumjjb lumjjb approved these changes

@pxp928 pxp928 pxp928 approved these changes

@mihaimaruseac mihaimaruseac Awaiting requested review from mihaimaruseac mihaimaruseac is a code owner

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rmetzman @lumjjb @pxp928