Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add guac friends md #1080

Merged
merged 1 commit into from Jul 20, 2023
Merged

add guac friends md #1080

merged 1 commit into from Jul 20, 2023

Conversation

lumjjb
Copy link
Contributor

@lumjjb lumjjb commented Jul 20, 2023

Description of the PR

Add friends of GUAC as discussed during the community meeting.

Related: #1020

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@lumjjb
add guac friends md
ed50980 
Signed-off-by: Brandon Lum <lumjjb@gmail.com>
pxp928
pxp928 approved these changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

GUAC_FRIENDS.md Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit d988552 into main Jul 20, 2023
9 checks passed
@kodiakhq kodiakhq bot deleted the add-friends branch July 20, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxp928 pxp928 pxp928 approved these changes

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@trmiller trmiller trmiller approved these changes

@mlieberman85 mlieberman85 Awaiting requested review from mlieberman85

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lumjjb @mihaimaruseac @trmiller @pxp928