Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding check for docker builx toolkit in Makefile to fix#1057 #1083

Merged
merged 1 commit into from Jul 24, 2023
Merged

Adding check for docker builx toolkit in Makefile to fix#1057 #1083

merged 1 commit into from Jul 24, 2023

Conversation

arorasoham9
Copy link
Contributor

Description of the PR

Fixes #1057

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@pxp928 pxp928 requested a review from sunnyyip July 20, 2023 21:19
@arorasoham9
Adding check for docker builx toolkit in Makefile to fix#1057
b83869a 
Signed-off-by: Soham Arora <arorasoham9@gmail.com>
@kodiakhq kodiakhq bot merged commit 73359ad into guacsec:main Jul 24, 2023
9 checks passed
@s-spindler s-spindler mentioned this pull request Aug 16, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@lumjjb lumjjb lumjjb approved these changes

@sunnyyip sunnyyip Awaiting requested review from sunnyyip

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] make container fails with unrecognized --builder flag
3 participants
@arorasoham9 @mihaimaruseac @lumjjb