-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PatchPlanning] Add PointOfContact predicate #1088
Conversation
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GraphQL changes look good, I only skimmed through the files in guacanalytics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question, else lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple comments else LGTM
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
* in progress Signed-off-by: Rebecca Metzman <rmetzman@google.com> * in progress Signed-off-by: Rebecca Metzman <rmetzman@google.com> * trying to find fields Signed-off-by: Rebecca Metzman <rmetzman@google.com> * regerate Signed-off-by: Rebecca Metzman <rmetzman@google.com> * added code poc Signed-off-by: Rebecca Metzman <rmetzman@google.com> * files to add Signed-off-by: Rebecca Metzman <rmetzman@google.com> * delete usued line Signed-off-by: Rebecca Metzman <rmetzman@google.com> * fixing some comments Signed-off-by: Rebecca Metzman <rmetzman@google.com> --------- Signed-off-by: Rebecca Metzman <rmetzman@google.com> Co-authored-by: Rebecca Metzman <rmetzman@google.com>
Description of the PR
Add POC predicate to patch planning
PR Checklist
-s
flag togit commit
.make generate
has been runcollectsub
protobuf has been changed,make proto
has been run