Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PatchPlanning] Add PointOfContact predicate #1088

Merged
merged 9 commits into from Jul 25, 2023

Conversation

rmetzman
Copy link
Contributor

Description of the PR

Add POC predicate to patch planning

  • regenerate files to update POC fields
  • rename DfsNode to BfsNode to reflect code functionality

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

Rebecca Metzman and others added 6 commits July 21, 2023 17:30
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Rebecca Metzman added 2 commits July 24, 2023 20:33
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
@rmetzman rmetzman marked this pull request as ready for review July 24, 2023 20:49
Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GraphQL changes look good, I only skimmed through the files in guacanalytics.

Copy link
Contributor

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question, else lgtm

pkg/guacanalytics/patchPlanning.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple comments else LGTM

pkg/guacanalytics/patchPlanning.go Outdated Show resolved Hide resolved
pkg/guacanalytics/patchPlanning_test.go Show resolved Hide resolved
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
@kodiakhq kodiakhq bot merged commit 9368f3a into guacsec:main Jul 25, 2023
9 checks passed
rmetzman added a commit to rmetzman/guac that referenced this pull request Aug 4, 2023
* in progress

Signed-off-by: Rebecca Metzman <rmetzman@google.com>

* in progress

Signed-off-by: Rebecca Metzman <rmetzman@google.com>

* trying to find fields

Signed-off-by: Rebecca Metzman <rmetzman@google.com>

* regerate

Signed-off-by: Rebecca Metzman <rmetzman@google.com>

* added code poc

Signed-off-by: Rebecca Metzman <rmetzman@google.com>

* files to add

Signed-off-by: Rebecca Metzman <rmetzman@google.com>

* delete usued line

Signed-off-by: Rebecca Metzman <rmetzman@google.com>

* fixing some comments

Signed-off-by: Rebecca Metzman <rmetzman@google.com>

---------

Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Co-authored-by: Rebecca Metzman <rmetzman@google.com>
@rmetzman rmetzman changed the title Add PointOfContact predicate to PatchPlanning [PatchPlanning] Add PointOfContact predicate Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants