Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-1105 inmem HasSBOM: manage no hasSBOMSpec sent #1106

Merged
merged 2 commits into from Jul 31, 2023

Conversation

mrizzi
Copy link
Collaborator

@mrizzi mrizzi commented Jul 31, 2023

Description of the PR

  • checks for nil filter before retrieving by ID
  • checks for nil filter in addHasSBOMIfMatch method to have c.convHasSBOM(link) to be executed

1st commit has the test reproducer for the issue so it's expected to fail the CI tests
2nd commit the fix (and should run fine the tests 馃槄 )

Fixes #1105

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

Signed-off-by: mrizzi <mrizzi@redhat.com>
Signed-off-by: mrizzi <mrizzi@redhat.com>
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jul 31, 2023
@kodiakhq kodiakhq bot merged commit febfb54 into guacsec:main Jul 31, 2023
9 checks passed
@mrizzi mrizzi deleted the issue-1105 branch July 31, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] nil pointer when running HasSBOM query with no hasSBOMSpec
3 participants