Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PatchPlanning] Add CLI cmd for patch planning #1129

Merged
merged 17 commits into from Aug 8, 2023
Merged

[PatchPlanning] Add CLI cmd for patch planning #1129

merged 17 commits into from Aug 8, 2023

Conversation

rmetzman
Copy link
Contributor

@rmetzman rmetzman commented Aug 4, 2023

Description of the PR

  • Add support for patch planning cli cmd (named patch)
  • Fix some bugs in the guacanalytics folder

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

Rebecca Metzman added 2 commits August 4, 2023 18:33
fixing
9b17969 
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
adding other changed
b47fdfc 
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
lint error
97e29a5 
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
@rmetzman rmetzman marked this pull request as ready for review August 4, 2023 19:12
lumjjb
lumjjb reviewed Aug 7, 2023
View reviewed changes
Copy link
Contributor

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initial review comments

cmd/guacone/cmd/patch.go Outdated Show resolved Hide resolved
cmd/guacone/cmd/patch.go Outdated Show resolved Hide resolved
cmd/guacone/cmd/patch.go Outdated Show resolved Hide resolved
Rebecca Metzman added 3 commits August 7, 2023 15:46
fixing todo
4fd93d9 
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
fixing println
265e3dd 
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
validate
aa872d2 
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
@rmetzman rmetzman requested a review from lumjjb August 7, 2023 16:15
@rmetzman rmetzman mentioned this pull request Aug 7, 2023
Closed
pxp928
pxp928 reviewed Aug 7, 2023
View reviewed changes
pkg/cli/store.go Outdated Show resolved Hide resolved
cmd/guacone/cmd/patch.go Outdated Show resolved Hide resolved
cmd/guacone/cmd/patch.go Outdated Show resolved Hide resolved
cmd/guacone/cmd/patch.go Outdated Show resolved Hide resolved
cmd/guacone/cmd/patch.go Show resolved Hide resolved
cmd/guacone/cmd/patch.go Show resolved Hide resolved
cmd/guacone/cmd/patch.go Outdated Show resolved Hide resolved
cmd/guacone/cmd/patch.go Outdated Show resolved Hide resolved
pkg/guacanalytics/helpers.go Outdated Show resolved Hide resolved
pkg/guacanalytics/toposort.go Outdated Show resolved Hide resolved
Rebecca Metzman added 4 commits August 7, 2023 20:55
review changes 2
a4800da 
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
fixing comments
8614a22 
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
fixing tooo
330bd02 
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
fixing comments 3
b0334a7 
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
@rmetzman rmetzman requested a review from pxp928 August 7, 2023 21:40
Rebecca Metzman added 2 commits August 8, 2023 19:11
removing test from code
b9d4214 
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
removing test ingestion
1c9d949 
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Rebecca Metzman added 2 commits August 8, 2023 19:33
pkgtopurl
466520c 
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
minor
b50b0b9 
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
lumjjb
lumjjb approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits , else LGTM

cmd/guacone/cmd/patch.go Outdated Show resolved Hide resolved
cmd/guacone/cmd/patch.go Show resolved Hide resolved
cmd/guacone/cmd/patch.go Show resolved Hide resolved
pxp928
pxp928 approved these changes Aug 8, 2023
View reviewed changes
Copy link
Collaborator

@pxp928 pxp928 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @rmetzman. Will have to rebase on main for it to auto-merge

rmetzman and others added 3 commits August 8, 2023 20:31
@rmetzman
Merge branch 'main' into cli-draft1
7e2dbfe
fixing nits
5ddd6a5 
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
fixing flag
bcacef9 
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
@kodiakhq kodiakhq bot merged commit 7d1960b into guacsec:main Aug 8, 2023
9 checks passed
@rmetzman rmetzman mentioned this pull request Aug 8, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumjjb lumjjb lumjjb approved these changes

@pxp928 pxp928 pxp928 approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rmetzman @lumjjb @pxp928