Tag ent tests #1200
Merged
Tag ent tests #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put ent tests behind tag integrationEnt until we have infra to bring up a postgres instance in our integration tests. Signed-off-by: Jeff Mendoza <jlm@jlm.name>
pxp928
approved these changes
Aug 29, 2023
|
Note: postgres is being brought up in the CI workflow but not in the postmerge workflow yet causing it to fail. @jeffmendoza did we want to make an issue to capture this? |
|
Oh, I see. I'll update this one then. |
Update workflows to only startup postgres on integration tests. Remove uneccessary github secret references, those are only used in integration-merge tests. Signed-off-by: Jeff Mendoza <jlm@jlm.name>
mihaimaruseac
approved these changes
Aug 30, 2023
m-brophy
pushed a commit
to m-brophy/guac
that referenced
this pull request
Aug 31, 2023
* Tag ent tests Put ent tests behind tag integrationEnt until we have infra to bring up a postgres instance in our integration tests. Signed-off-by: Jeff Mendoza <jlm@jlm.name> * Tag ent tests with integration Update workflows to only startup postgres on integration tests. Remove uneccessary github secret references, those are only used in integration-merge tests. Signed-off-by: Jeff Mendoza <jlm@jlm.name> --------- Signed-off-by: Jeff Mendoza <jlm@jlm.name> Signed-off-by: m-brophy <mbrophy@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put ent tests behind tag integrationEnt until we have infra to bring up a postgres instance in our integration tests.