Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Legal information schema and inmem backend. #1207

Merged
merged 4 commits into from Sep 1, 2023

Conversation

jeffmendoza
Copy link
Collaborator

License noun node and CertifyLegal verb node added. Client operations added. Inmem implementation added. License input verification added to resolver. CertifyLegal input verification not added to resolver yet, as it will be a cut and paste of others Certify verb nodes when those are moved to the resolver soon. Other backends are not implemented yet, will be soon.

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

License noun node and CertifyLegal verb node added. Client operations
added. Inmem implementation added. License input verification added to
resolver. CertifyLegal input verification not added to resolver yet, as it will
be a cut and paste of others Certify verb nodes when those are moved to the
resolver soon. Other backends are not implemented yet, will be soon.

Signed-off-by: Jeff Mendoza <jlm@jlm.name>
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Added couple of comments

pkg/assembler/graphql/schema/license.graphql Outdated Show resolved Hide resolved
pkg/assembler/graphql/schema/certifyLegal.graphql Outdated Show resolved Hide resolved
pkg/assembler/clients/operations/license.graphql Outdated Show resolved Hide resolved
pkg/assembler/clients/operations/certifyLegal.graphql Outdated Show resolved Hide resolved
pkg/assembler/backends/helper/validation.go Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit 68e0455 into guacsec:main Sep 1, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants