Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ingestor/Assembler and SPDX Parser for Legal information. #1244

Merged
merged 2 commits into from Sep 14, 2023
Merged

Ingestor/Assembler and SPDX Parser for Legal information. #1244

merged 2 commits into from Sep 14, 2023

Conversation

jeffmendoza
Copy link
Collaborator

Description of the PR

Not sure if we should create "License" nodes for SPDX exceptions, or just leave them in the expression only.

Suggestions on default Justification ""Found in SPDX document." appreciated.

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@jeffmendoza jeffmendoza mentioned this pull request Sep 8, 2023
Open
pxp928
pxp928 approved these changes Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@pxp928 pxp928 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. minor comments and a question

pkg/assembler/assembler.go Show resolved Hide resolved
pkg/assembler/clients/helpers/bulk.go Show resolved Hide resolved
pkg/ingestor/parser/spdx/parse_spdx.go Show resolved Hide resolved
@pxp928 pxp928 requested a review from lumjjb September 13, 2023 11:46
@jeffmendoza
Ingestor/Assembler and SPDX Parser for Legal information.
ee9d124 
Signed-off-by: Jeff Mendoza <jlm@jlm.name>
@jeffmendoza
Add license unit test to assembler.
922dba8 
Signed-off-by: Jeff Mendoza <jlm@jlm.name>
mihaimaruseac
mihaimaruseac approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question

pkg/ingestor/parser/common/license.go Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit ebd91bb into guacsec:main Sep 14, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@pxp928 pxp928 pxp928 approved these changes

@lumjjb lumjjb Awaiting requested review from lumjjb

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jeffmendoza @mihaimaruseac @pxp928