Fix/add missing unit tests arango #1246

pxp928 · 2023-09-10T22:30:45Z

Description of the PR

All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
All new changes are covered by tests
If GraphQL schema is changed, make generate has been run
If collectsub protobuf has been changed, make proto has been run
All CI checks are passing (tests and formatting)
All dependent PRs have already been merged

Signed-off-by: pxp928 <parth.psu@gmail.com>

pkg/assembler/backends/arangodb/certifyBad_test.go

Signed-off-by: pxp928 <parth.psu@gmail.com>

add ID check unit tests

6a13eb8

Signed-off-by: pxp928 <parth.psu@gmail.com>

pxp928 requested a review from mihaimaruseac as a code owner September 10, 2023 22:30

pull-request-size bot added the size/XXL label Sep 10, 2023

add missing unit test to check for IDs

c526d6f

Signed-off-by: pxp928 <parth.psu@gmail.com>

pxp928 force-pushed the fix/add-missing-tests-arango branch from 165cce5 to c526d6f Compare September 10, 2023 22:49

pxp928 requested review from jeffmendoza and lumjjb September 10, 2023 22:53

mihaimaruseac approved these changes Sep 11, 2023

View reviewed changes

pxp928 commented Sep 11, 2023

View reviewed changes

pkg/assembler/backends/arangodb/certifyBad_test.go Outdated Show resolved Hide resolved

change fom test name to test flags

54770c6

Signed-off-by: pxp928 <parth.psu@gmail.com>

jeffmendoza approved these changes Sep 11, 2023

View reviewed changes

kodiakhq bot merged commit 4589fbf into guacsec:main Sep 11, 2023
9 checks passed

pxp928 deleted the fix/add-missing-tests-arango branch September 11, 2023 17:29