Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ent - IngestSLSAs implementation with tests #1248

Merged
merged 1 commit into from Sep 11, 2023
Merged

Ent - IngestSLSAs implementation with tests #1248

merged 1 commit into from Sep 11, 2023

Conversation

mrizzi
Copy link
Collaborator

@mrizzi mrizzi commented Sep 11, 2023

Description of the PR

Ent - IngestSLSAs implementation with tests (as usual tests reflect the inmem ones)

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@mrizzi
Ent - IngestSLSAs implementation with tests
10ab791 
Signed-off-by: mrizzi <mrizzi@redhat.com>
pxp928
pxp928 reviewed Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will let @jeffmendoza give final approval

@kodiakhq kodiakhq bot merged commit 40d3454 into guacsec:main Sep 11, 2023
9 checks passed
@mrizzi mrizzi deleted the ent-IngestSLSAs branch September 12, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxp928 pxp928 pxp928 left review comments

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@jeffmendoza jeffmendoza jeffmendoza approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mrizzi @mihaimaruseac @jeffmendoza @pxp928