Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update resolvers for legal nodes and add tests. #1269

Merged
merged 1 commit into from Sep 15, 2023
Merged

Update resolvers for legal nodes and add tests. #1269

merged 1 commit into from Sep 15, 2023

Conversation

jeffmendoza
Copy link
Collaborator

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@jeffmendoza
Update resolvers for legal nodes and add tests.
2fa6808 
Signed-off-by: Jeff Mendoza <jlm@jlm.name>
mihaimaruseac
mihaimaruseac approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jeffmendoza jeffmendoza mentioned this pull request Sep 14, 2023
Open
@kodiakhq kodiakhq bot merged commit 5fe78f7 into guacsec:main Sep 15, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@pxp928 pxp928 pxp928 approved these changes

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jeffmendoza @mihaimaruseac @pxp928