Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use officially released go-vex dependency v0.2.1 #1284

Merged
merged 2 commits into from Sep 18, 2023
Merged

use officially released go-vex dependency v0.2.1 #1284

merged 2 commits into from Sep 18, 2023

Conversation

m-brophy
Copy link
Contributor

@m-brophy m-brophy commented Sep 18, 2023 •
edited

Description of the PR

Previously the go-vex dependency used in guac was not an official release

Fixes #1017

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@m-brophy
use officially released go-vex dependency
f57f270 
Signed-off-by: m-brophy <mbrophy@redhat.com>
pxp928
pxp928 reviewed Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @m-brophy, a rebase on main will fix the CI issue.

go.mod Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit 82d666d into guacsec:main Sep 18, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffmendoza jeffmendoza jeffmendoza approved these changes

@pxp928 pxp928 pxp928 approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] Upgrade go-vex dependency to a released version
3 participants
@m-brophy @jeffmendoza @pxp928