Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/arango node query #1301

Merged
merged 4 commits into from Sep 20, 2023
Merged

Feature/arango node query #1301

merged 4 commits into from Sep 20, 2023

Conversation

pxp928
Copy link
Collaborator

@pxp928 pxp928 commented Sep 20, 2023

Description of the PR

initial implementation of the node query for arangoDB (currently only implemented for package and source nodes). Will continue with the implementation once the maintainer's feedback is received.

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Copy link
Collaborator

@jeffmendoza jeffmendoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I see this logic is somewhat copied from the similar funcs in the inmem backend. We use the filter there for a lot of operations, but not here. Will we be doing more refactoring to use it?

pkg/assembler/backends/arangodb/path.go Outdated Show resolved Hide resolved
pkg/assembler/backends/arangodb/path.go Outdated Show resolved Hide resolved
pkg/assembler/backends/arangodb/path.go Outdated Show resolved Hide resolved
Signed-off-by: pxp928 <parth.psu@gmail.com>
@kodiakhq kodiakhq bot merged commit f8b701e into guacsec:main Sep 20, 2023
9 checks passed
@pxp928 pxp928 deleted the feature/arango-path branch September 20, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants