update docker manifest name in nightly releases #1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Deicas <mdeicas@google.com>
|
Let's also remove this comment if we were to align the tag between bins and container image - https://github.com/guacsec/guac/blob/main/.goreleaser-nightly.yaml#L217. |
Signed-off-by: Marco Deicas <mdeicas@google.com>
pxp928
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the PR
The docker manifest in the nightly releases are named
nightlyinstead ofv0-nightlywhich is the release tag. This is inconsistent with.goreleaser.yamland with the expected manifest name ofv0-nightlyin the.envfile in the nightly release compose tarball.