Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug in hasSLSA for arango #1303

Merged
merged 1 commit into from Sep 20, 2023
Merged

fix bug in hasSLSA for arango #1303

merged 1 commit into from Sep 20, 2023

Conversation

pxp928
Copy link
Collaborator

@pxp928 pxp928 commented Sep 20, 2023 •
edited

Description of the PR

  • fix a bug in hasSLSA around the builtFromKeyList and builder query
  • added new tests to ensure fix

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@pxp928
fix bug in hasSLSA for arango
97c1897 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@kodiakhq kodiakhq bot merged commit fa78489 into guacsec:main Sep 20, 2023
9 checks passed
@pxp928 pxp928 deleted the fix/hasSLSA-ingest branch September 20, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@jeffmendoza jeffmendoza jeffmendoza approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pxp928 @mihaimaruseac @jeffmendoza