Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confusing name of field in IsDependency GraphQL #1305

Merged
merged 1 commit into from Sep 21, 2023
Merged

Confusing name of field in IsDependency GraphQL #1305

merged 1 commit into from Sep 21, 2023

Conversation

desmax74
Copy link
Contributor

@desmax74 desmax74 commented Sep 21, 2023 •
edited

Fixes #1293

Description of the PR

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@desmax74
Confusing name of field in IsDependency GraphQL
1d3c69f 
Signed-off-by: desmax74 <mdessi@redhat.com>
pxp928
pxp928 approved these changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @desmax74

@kodiakhq kodiakhq bot merged commit c46528b into guacsec:main Sep 21, 2023
9 checks passed
@desmax74 desmax74 deleted the maxplayground branch October 19, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@pxp928 pxp928 pxp928 approved these changes

@jeffmendoza jeffmendoza Awaiting requested review from jeffmendoza jeffmendoza is a code owner

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusing name of field in IsDependency GraphQL
3 participants
@desmax74 @mihaimaruseac @pxp928