Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process PACKAGE_OF relationship in SPDX files #1337

Merged
merged 5 commits into from Oct 9, 2023

Conversation

m-brophy
Copy link
Contributor

@m-brophy m-brophy commented Oct 2, 2023

Description of the PR

PACKAGE_OF relationships were previously not processed if present in ingested files

Fixes #1331

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

Copy link
Contributor

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pkg/ingestor/parser/spdx/parse_spdx.go Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/L and removed size/S labels Oct 6, 2023
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@lumjjb
Copy link
Contributor

lumjjb commented Oct 8, 2023

Yea, for this repo, we highly discourage merge commits as we are using the rebase workflow, goign to try to attempt a rebase through github workflow (ok that failed probably due to the conflicts)

@m-brophy
Copy link
Contributor Author

m-brophy commented Oct 9, 2023

Apologies, I clicked the workflow button to update the branch before I'd read the comments about preferring to rebase. If this is unacceptable let me know and i'll try to rollback the branch locally, rebase then push to the PR

@pxp928
Copy link
Collaborator

pxp928 commented Oct 9, 2023

Apologies, I clicked the workflow button to update the branch before I'd read the comments about preferring to rebase. If this is unacceptable let me know and i'll try to rollback the branch locally, rebase then push to the PR

Yes please rebase.

Signed-off-by: m-brophy <mbrophy@redhat.com>
Signed-off-by: m-brophy <mbrophy@redhat.com>
Signed-off-by: m-brophy <mbrophy@redhat.com>
Signed-off-by: m-brophy <mbrophy@redhat.com>
Signed-off-by: m-brophy <mbrophy@redhat.com>
@m-brophy
Copy link
Contributor Author

m-brophy commented Oct 9, 2023

Apologies, I clicked the workflow button to update the branch before I'd read the comments about preferring to rebase. If this is unacceptable let me know and i'll try to rollback the branch locally, rebase then push to the PR

Yes please rebase.

I've done this now, thanks for the advice

@kodiakhq kodiakhq bot merged commit 09c5879 into guacsec:main Oct 9, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ingestion/data-quality issue] Support PACKAGE_OF relations in SPDX files
5 participants