New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
process PACKAGE_OF
relationship in SPDX files
#1337
Conversation
64ea770
to
ec7a06e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
8b7d2b7
to
822f0b6
Compare
822f0b6
to
6276ee8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
Yea, for this repo, we highly discourage merge commits as we are using the rebase workflow, goign to try to attempt a rebase through github workflow (ok that failed probably due to the conflicts) |
Apologies, I clicked the workflow button to update the branch before I'd read the comments about preferring to rebase. If this is unacceptable let me know and i'll try to rollback the branch locally, rebase then push to the PR |
Yes please rebase. |
Signed-off-by: m-brophy <mbrophy@redhat.com>
Signed-off-by: m-brophy <mbrophy@redhat.com>
Signed-off-by: m-brophy <mbrophy@redhat.com>
Signed-off-by: m-brophy <mbrophy@redhat.com>
Signed-off-by: m-brophy <mbrophy@redhat.com>
aba40e8
to
31a123d
Compare
I've done this now, thanks for the advice |
Description of the PR
PACKAGE_OF
relationships were previously not processed if present in ingested filesFixes #1331
PR Checklist
-s
flag togit commit
.make generate
has been runcollectsub
protobuf has been changed,make proto
has been run