Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include Timestamps for Verbs #1338

Merged
merged 7 commits into from Oct 4, 2023
Merged

Include Timestamps for Verbs #1338

merged 7 commits into from Oct 4, 2023

Conversation

nathannaveen
Copy link
Contributor

Description of the PR

Fixes #1030

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@nathannaveen
Copy link
Contributor Author

👀 @pxp928

pxp928
pxp928 approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! question regarding utc and further implementation for other backends

pkg/assembler/backends/inmem/hasSBOM.go Outdated Show resolved Hide resolved
@nathannaveen
Included Timestamp for Verbs
767943c 
* Fixes guacsec#1030

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@nathannaveen
Edited GraphQL
1d8fd66 
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@nathannaveen
Fixed some stuff
101e264 
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@nathannaveen
Fixed SBOM issue
7ace7f3 
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@nathannaveen
Fixed tests
c81d53f 
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@nathannaveen
Stored Times to UTC
354745c 
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@nathannaveen
Updated spec
3e347fb 
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@nathannaveen nathannaveen force-pushed the nathan/IncludeTimestampsForVerbs branch from 70652e2 to 3e347fb Compare October 4, 2023 17:08
@kodiakhq kodiakhq bot merged commit d681a8d into guacsec:main Oct 4, 2023
9 checks passed
@nathannaveen nathannaveen deleted the nathan/IncludeTimestampsForVerbs branch October 4, 2023 22:10
nathannaveen added a commit to nathannaveen/guac-docs that referenced this pull request Oct 4, 2023
@nathannaveen
Updated graphql File with Timestamps
d0cd7bb 
* Updated based on guacsec/guac#1338

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@nathannaveen nathannaveen mentioned this pull request Oct 4, 2023
Merged
@dejanb dejanb mentioned this pull request Oct 5, 2023
Open
This was referenced Oct 5, 2023
Open
Open
@nathannaveen nathannaveen mentioned this pull request Oct 13, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxp928 pxp928 pxp928 approved these changes

@jeffmendoza jeffmendoza jeffmendoza approved these changes

@mihaimaruseac mihaimaruseac Awaiting requested review from mihaimaruseac mihaimaruseac is a code owner

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] Add timestamp to verbs that don't have them
3 participants
@nathannaveen @jeffmendoza @pxp928