Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for guac server to start before running tests #1383

Merged
merged 1 commit into from Oct 11, 2023
Merged

Wait for guac server to start before running tests #1383

merged 1 commit into from Oct 11, 2023

Conversation

mrizzi
Copy link
Collaborator

@mrizzi mrizzi commented Oct 11, 2023

Description of the PR

Based upon 890fe58 and this comment #1365 (comment)

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@knrc @mrizzi
Wait for guac server to start before running tests
45464b7 
Signed-off-by: Kevin Conner <kev.conner@gmail.com>
@mrizzi mrizzi mentioned this pull request Oct 11, 2023
Merged
6 tasks
@kodiakhq kodiakhq bot merged commit e48e534 into guacsec:main Oct 11, 2023
9 checks passed
@mrizzi mrizzi deleted the e2e-wait-guacgql branch October 11, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumjjb lumjjb lumjjb approved these changes

@pxp928 pxp928 pxp928 approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mrizzi @lumjjb @pxp928 @knrc