edit arangosearch view to exclude subpath search results #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brandon Lum <lumjjb@gmail.com>
lumjjb
requested review from
pxp928,
mihaimaruseac and
jeffmendoza
and removed request for
mihaimaruseac
mihaimaruseac
approved these changes
Oct 12, 2023
pxp928
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the PR
Due to there being a ton of filenames, the current stop gap fix is to not index in the arangosearch for subpath values. The longer term solution should probably look more like being able to query package /source or other software tried with a wildcard search, or have search allow exclusion of certain words.
PR Checklist
-sflag togit commit.make generatehas been runcollectsubprotobuf has been changed,make protohas been run