Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ent - VulnerabilityMetadata endpoints #1416

Merged
merged 1 commit into from Oct 19, 2023
Merged

Ent - VulnerabilityMetadata endpoints #1416

merged 1 commit into from Oct 19, 2023

Conversation

mrizzi
Copy link
Collaborator

@mrizzi mrizzi commented Oct 18, 2023

Description of the PR

Ent implementation for VulnerabilityMetadata endpoints with tests from the inmem backend's ones.

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@mrizzi
Ent - VulnerabilityMetadata endpoints
314f738 
Signed-off-by: mrizzi <mrizzi@redhat.com>
pxp928
pxp928 approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one timestamp consistency between backends

pkg/assembler/backends/ent/backend/vulnMetadata.go Show resolved Hide resolved
@pxp928 pxp928 added the needs-review Needs writer LGTM label Oct 19, 2023
@kodiakhq kodiakhq bot merged commit 1b4e681 into guacsec:main Oct 19, 2023
9 checks passed
@mrizzi mrizzi deleted the ent-VulnerabilityMetadata branch October 19, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@pxp928 pxp928 pxp928 approved these changes

Assignees
No one assigned
Labels
needs-review Needs writer LGTM size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mrizzi @mihaimaruseac @pxp928