Encoding guesser #1472
Merged
Encoding guesser #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-brophy
force-pushed
the
encoding_guesser
branch
2 times, most recently
from
70583ac
to
759a0b6
Compare
lumjjb
reviewed
Nov 23, 2023
|
Hey @m-brophy ! Just checking back on this! The PR looks almost ready to merge with some minor nits. |
m-brophy
force-pushed
the
encoding_guesser
branch
from
1e0c59f
to
aa20c8a
Compare
|
Hi @lumjjb, changes made, branch rebased, CI tests all successful if you want to take another look now. |
Signed-off-by: m-brophy <mbrophy@redhat.com>
Signed-off-by: m-brophy <mbrophy@redhat.com>
Signed-off-by: m-brophy <mbrophy@redhat.com>
Signed-off-by: m-brophy <mbrophy@redhat.com>
Signed-off-by: m-brophy <mbrophy@redhat.com>
Signed-off-by: m-brophy <mbrophy@redhat.com>
Signed-off-by: m-brophy <mbrophy@redhat.com>
Signed-off-by: m-brophy <mbrophy@redhat.com>
m-brophy
force-pushed
the
encoding_guesser
branch
from
72ef396
to
2f157a4
Compare
|
Hey @lumjjb I just rebased this ready to merge if you're happy to do that |
lumjjb
approved these changes
Jan 18, 2024
Signed-off-by: Jeff Mendoza <jlm@jlm.name>
jeffmendoza
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the PR
This PR enables guac to detect the encoding of a compressed file from the internal bytes of the document, for use if this information isn't supplied separately
Fixes #1237
http.DetectContentTypeis used but this does not handlebz2orzstencoding so this capability has been addedthese docs were used as a reference for detection of these types: https://www.ietf.org/rfc/rfc8878.txt and https://www.ietf.org/rfc/rfc5655.txt
PR Checklist
-sflag togit commit.make generatehas been runcollectsubprotobuf has been changed,make protohas been run