Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inlcuded a faster fmt #1507

Merged
merged 2 commits into from Dec 7, 2023
Merged

Inlcuded a faster fmt #1507

merged 2 commits into from Dec 7, 2023

Conversation

nathannaveen
Copy link
Contributor

Description of the PR

  • make fmt takes an extremely long time so I created fmt-local.
  • fmt-local doesn't break the CI.
  • fmt-local works by only running on files that are changed.

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@nathannaveen
Inlcuded a faster fmt
096f65a 
* `make fmt` takes an extremely long time so I created `fmt-local`.
* `fmt-local` doesn't break the CI.
* `fmt-local` works by only running on files that are changed.

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
lumjjb
lumjjb approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice addition - minor nit on naming

Makefile Outdated Show resolved Hide resolved
pxp928
pxp928 reviewed Dec 7, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@nathannaveen nathannaveen force-pushed the nathan/fasterFmt branch 2 times, most recently from b0829aa to 6b7c1ac Compare December 7, 2023 13:59
@nathannaveen nathannaveen force-pushed the nathan/fasterFmt branch 2 times, most recently from 1b0ab5a to 63930ff Compare December 7, 2023 15:19
@nathannaveen
Replaced the previous fmt
037425f 
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@kodiakhq kodiakhq bot merged commit c72e762 into guacsec:main Dec 7, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumjjb lumjjb lumjjb approved these changes

@pxp928 pxp928 pxp928 approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nathannaveen @lumjjb @pxp928