Create a single backend acceptance test suite. #1597
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new integration test suite is added under internal/testing/backend to test all backends with the same set of tests. All the test scaffolding is seutp to run all the backends. Only "CertifyBad" tests have been copied in in this first commit.
Arango, keyvalue, and ent tests are all close copies of each other. A large amount of work in implementing API changes is updating the tests for each backend. Also, we wish to have a gold standard test suite so that new backends can be tested to the same standards as the existing ones. This code supports adding new backends piecemeal and skipping tests on unimplemented node types.
I've only put CertifyBad here now, so all the setup can be reviewed before I move all the types over. The plan is to remove all the integration tests from arango, keyvalue, and ent, and just use these.
PR Checklist
-s
flag togit commit
.make generate
has been runcollectsub
protobuf has been changed,make proto
has been run