Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default blob-addr to use filesystem (for docker-compose and k8s) #1666

Merged
merged 3 commits into from Jan 29, 2024
Merged

Update default blob-addr to use filesystem (for docker-compose and k8s) #1666

merged 3 commits into from Jan 29, 2024

Conversation

pxp928
Copy link
Collaborator

@pxp928 pxp928 commented Jan 27, 2024 •
edited

Description of the PR

Update the the blob-addr to be filesystem for docker-compose and k8s. Adds a shared volume between the collector and ingestor container for blob store.

The address is now set to file:///tmp/blobstore?no_tmp_dir=true

Note: no_tmp_dir=true is need to get around google/go-cloud#3294

closes #1650

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@pxp928 pxp928 force-pushed the update-blob-addr branch 2 times, most recently from 773b339 to 24ebb4c Compare January 29, 2024 14:48
@pxp928 @lumjjb
update docker compose and k8s with persistent volume
c124552 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928 @lumjjb
add no_tmp_dir to fix local file blob store
3c4f983 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928 @lumjjb
fix typo
d7c37f2 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@kodiakhq kodiakhq bot merged commit b0969e3 into guacsec:main Jan 29, 2024
8 checks passed
@pxp928 pxp928 deleted the update-blob-addr branch January 29, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@lumjjb lumjjb lumjjb approved these changes

@jeffmendoza jeffmendoza Awaiting requested review from jeffmendoza jeffmendoza is a code owner

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] Add a shared volume/directory between the collector and ingestor container for blob store
3 participants
@pxp928 @mihaimaruseac @lumjjb