Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error and exit when initialization fails #1674

Merged
merged 2 commits into from Jan 30, 2024
Merged

Error and exit when initialization fails #1674

merged 2 commits into from Jan 30, 2024

Conversation

pxp928
Copy link
Collaborator

@pxp928 pxp928 commented Jan 29, 2024

Description of the PR

change to Fatalf instead of Errorf when initialization fails

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@pxp928
change to fatalf instead of errorf when initialization fails
53c11da 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
use Fatalf consistently
61ba2df 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@kodiakhq kodiakhq bot merged commit f750549 into guacsec:main Jan 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@jeffmendoza jeffmendoza jeffmendoza approved these changes

@lumjjb lumjjb Awaiting requested review from lumjjb

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pxp928 @mihaimaruseac @jeffmendoza