Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Included Polling for Github Collect #1678

Merged
merged 1 commit into from Mar 6, 2024
Merged

Included Polling for Github Collect #1678

merged 1 commit into from Mar 6, 2024

Conversation

nathannaveen
Copy link
Contributor

Description of the PR

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@pull-request-size pull-request-size bot added size/S and removed size/M labels Mar 6, 2024
@pxp928 pxp928 requested a review from jeffmendoza March 6, 2024 15:40
@nathannaveen
Included Polling for Github Collect
69a3b91 
* Fixes guacsec#1560

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@kodiakhq kodiakhq bot merged commit d4a9a96 into guacsec:main Mar 6, 2024
8 checks passed
@nathannaveen nathannaveen deleted the nathan/fixGithubPolling branch March 6, 2024 16:36
arorasoham9 pushed a commit to arorasoham9/guac that referenced this pull request Apr 1, 2024
@nathannaveen @arorasoham9
Included Polling for Github Collect (guacsec#1678)
6efbb99 
* Fixes guacsec#1560

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
arorasoham9 pushed a commit to arorasoham9/guac that referenced this pull request Apr 4, 2024
@nathannaveen @arorasoham9
Included Polling for Github Collect (guacsec#1678)
d50a679 
* Fixes guacsec#1560

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffmendoza jeffmendoza jeffmendoza approved these changes

@pxp928 pxp928 pxp928 approved these changes

@SantiagoTorres SantiagoTorres Awaiting requested review from SantiagoTorres

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timer for Github Polling is Missing
4 participants
@nathannaveen @jeffmendoza @SantiagoTorres @pxp928