Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing MAX_CONCURRENT_JOBS #1682

Merged
merged 3 commits into from Feb 5, 2024
Merged

removing MAX_CONCURRENT_JOBS #1682

merged 3 commits into from Feb 5, 2024

Conversation

arorasoham9
Copy link
Contributor

Description of the PR

Removing MAX_CONCURRENT_JOBS option

Attempt to fix #1433

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@arorasoham9
removing MAX_CONCURRENT_JOBS
4f7b01c 
Signed-off-by: Soham Arora <arorasoham9@gmail.com>
@arorasoham9
removing unnecessary import
3714ae3 
Signed-off-by: Soham Arora <arorasoham9@gmail.com>
pxp928
pxp928 reviewed Feb 1, 2024
View reviewed changes
cmd/guacone/cmd/files.go Outdated Show resolved Hide resolved
@arorasoham9
using regular ctx
d3cd585 
Signed-off-by: Soham Arora <arorasoham9@gmail.com>
@kodiakhq kodiakhq bot merged commit db6cfcc into guacsec:main Feb 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@pxp928 pxp928 pxp928 approved these changes

@jeffmendoza jeffmendoza Awaiting requested review from jeffmendoza jeffmendoza is a code owner

@lumjjb lumjjb Awaiting requested review from lumjjb

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] MAX_CONCURRENT_JOBS is no longer being used
3 participants
@arorasoham9 @mihaimaruseac @pxp928