Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented key value search #1711

Merged
merged 3 commits into from
Feb 26, 2024
Merged

Implemented key value search #1711

merged 3 commits into from
Feb 26, 2024

Conversation

nathannaveen
Copy link
Contributor

Description of the PR

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If OpenAPI spec is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@nathannaveen nathannaveen force-pushed the nathan/keyValueFindSoftware branch 2 times, most recently from 1c9ae1f to c75974f Compare February 20, 2024 16:05
@nathannaveen nathannaveen force-pushed the nathan/keyValueFindSoftware branch 2 times, most recently from 5747c8c to 60c48e2 Compare February 23, 2024 16:25
lumjjb
lumjjb approved these changes Feb 25, 2024
View reviewed changes
Copy link
Contributor

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! minor nit

internal/testing/backend/search_test.go Outdated Show resolved Hide resolved
pxp928
pxp928 approved these changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you add one more test case with source and package both returning.

internal/testing/backend/search_test.go Show resolved Hide resolved
internal/testing/backend/search_test.go Outdated Show resolved Hide resolved
@nathannaveen
Implemented key value search
6df75c7 
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@nathannaveen
Included tests for findSoftware
65302e0 
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@nathannaveen
Updated tests
5ff7adb 
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@kodiakhq kodiakhq bot merged commit 645dcbc into guacsec:main Feb 26, 2024
8 checks passed
@nathannaveen nathannaveen deleted the nathan/keyValueFindSoftware branch February 26, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@lumjjb lumjjb lumjjb approved these changes

@pxp928 pxp928 pxp928 approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] "FindSoftware" implementation for KeyValue
4 participants
@nathannaveen @mihaimaruseac @lumjjb @pxp928