Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README for the Github Collector #1731

Merged
merged 2 commits into from
Mar 7, 2024
Merged

README for the Github Collector #1731

merged 2 commits into from
Mar 7, 2024

Conversation

nathannaveen
Copy link
Contributor

Description of the PR

  • This is a README for the GitHub collector. This is mainly about how to run the GitHub collector for both workflow and release.

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If OpenAPI spec is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@nathannaveen
Readme for the github collector
82e9b56 
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@nathannaveen
Updated based on Code Review
8912217 
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@kodiakhq kodiakhq bot merged commit 67e4664 into guacsec:main Mar 7, 2024
8 checks passed
@nathannaveen nathannaveen deleted the nathan/gitCollectorReadme branch March 7, 2024 15:01
arorasoham9 pushed a commit to arorasoham9/guac that referenced this pull request Apr 1, 2024
@nathannaveen @arorasoham9
README for the Github Collector (guacsec#1731)
4545a19 
* Readme for the github collector

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>

* Updated based on Code Review

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>

---------

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
arorasoham9 pushed a commit to arorasoham9/guac that referenced this pull request Apr 4, 2024
@nathannaveen @arorasoham9
README for the Github Collector (guacsec#1731)
7d40c66 
* Readme for the github collector

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>

* Updated based on Code Review

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>

---------

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffmendoza jeffmendoza jeffmendoza approved these changes

@pxp928 pxp928 pxp928 approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nathannaveen @jeffmendoza @pxp928