Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove empty depends_on that fails validation. #1757

Merged
merged 1 commit into from Mar 7, 2024
Merged

Remove empty depends_on that fails validation. #1757

merged 1 commit into from Mar 7, 2024

Conversation

jeffmendoza
Copy link
Collaborator

Will need to redo the release.

Description of the PR

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If OpenAPI spec is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@jeffmendoza
Remove empty depends_on that fails validation.
1a61a07 
Signed-off-by: Jeff Mendoza <jlm@jlm.name>
@kodiakhq kodiakhq bot merged commit 1f9eb7c into guacsec:main Mar 7, 2024
8 checks passed
arorasoham9 pushed a commit to arorasoham9/guac that referenced this pull request Apr 1, 2024
@jeffmendoza @arorasoham9
Remove empty depends_on that fails validation. (guacsec#1757)
ff1d4db 
Signed-off-by: Jeff Mendoza <jlm@jlm.name>
arorasoham9 pushed a commit to arorasoham9/guac that referenced this pull request Apr 4, 2024
@jeffmendoza @arorasoham9
Remove empty depends_on that fails validation. (guacsec#1757)
63de566 
Signed-off-by: Jeff Mendoza <jlm@jlm.name>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@pxp928 pxp928 pxp928 approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jeffmendoza @mihaimaruseac @pxp928