Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include missing collectors #1759

Merged
merged 2 commits into from Mar 8, 2024
Merged

Include missing collectors #1759

merged 2 commits into from Mar 8, 2024

Conversation

nathannaveen
Copy link
Contributor

Description of the PR

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If OpenAPI spec is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@nathannaveen
Included S3 collector
a429652 
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@nathannaveen
Included GCS collector
ff5bb85 
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@nathannaveen nathannaveen force-pushed the nathan/missingGithubCollectors branch from 807914e to ff5bb85 Compare March 8, 2024 15:13
lumjjb
lumjjb approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@kodiakhq kodiakhq bot merged commit ac4c273 into guacsec:main Mar 8, 2024
8 checks passed
@nathannaveen nathannaveen deleted the nathan/missingGithubCollectors branch March 8, 2024 21:05
arorasoham9 pushed a commit to arorasoham9/guac that referenced this pull request Apr 1, 2024
@nathannaveen @arorasoham9
Include missing collectors (guacsec#1759)
fae39c4 
* Included S3 collector

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>

* Included GCS collector

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>

---------

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
arorasoham9 pushed a commit to arorasoham9/guac that referenced this pull request Apr 4, 2024
@nathannaveen @arorasoham9
Include missing collectors (guacsec#1759)
38417e6 
* Included S3 collector

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>

* Included GCS collector

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>

---------

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumjjb lumjjb lumjjb approved these changes

@pxp928 pxp928 pxp928 approved these changes

@jeffmendoza jeffmendoza Awaiting requested review from jeffmendoza jeffmendoza is a code owner

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] Add in missing collectors to guaccollect
3 participants
@nathannaveen @lumjjb @pxp928