Support image references by digest in the OCI collector #1779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If both a tag and digest are provided, the collector will ignore the tag. This follows how major clients like docker and crane treat references of this form. Signed-off-by: Rob Best <robertbest89@gmail.com>
|
LGTM! Thanks for submitting the PR, I never got around to it. The maintainers are all at Kubecon EU so it may be a few days before they can take a look |
pxp928
approved these changes
Mar 25, 2024
lumjjb
approved these changes
Mar 27, 2024
arorasoham9
pushed a commit
to arorasoham9/guac
that referenced
this pull request
Apr 1, 2024
If both a tag and digest are provided, the collector will ignore the tag. This follows how major clients like docker and crane treat references of this form. Signed-off-by: Rob Best <robertbest89@gmail.com>
arorasoham9
pushed a commit
to arorasoham9/guac
that referenced
this pull request
Apr 4, 2024
If both a tag and digest are provided, the collector will ignore the tag. This follows how major clients like docker and crane treat references of this form. Signed-off-by: Rob Best <robertbest89@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the PR
Modifies the OCI collector so that it supports image references by digest.
If both a tag and digest are provided, the collector will ignore the tag. This follows how major clients like docker and crane treat references of this form.
Fixes #1407
PR Checklist
-sflag togit commit.make generatehas been runmake generatehas been runcollectsubprotobuf has been changed,make protohas been run