Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix goreleaser flag deprecation warnings #1814

Merged
merged 1 commit into from Apr 5, 2024
Merged

Fix goreleaser flag deprecation warnings #1814

merged 1 commit into from Apr 5, 2024

Conversation

huggingpixels
Copy link
Contributor

Description of the PR

Fixes #1813
I spotted these minor deprecation warnings during local development. I tested the script on my local and it introduced no change in behaviour.
Thank you!

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If OpenAPI spec is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@huggingpixels
Fix goreleaser flag deprecation warnings
0d8a39a 
Signed-off-by: Eszter Szucs-Matyas <eszter.szucs.matyas@gmail.com>
@lumjjb lumjjb added the needs-review Needs writer LGTM label Apr 5, 2024
pxp928
pxp928 approved these changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank You for the Fix!

@kodiakhq kodiakhq bot merged commit 1381c07 into guacsec:main Apr 5, 2024
8 checks passed
arorasoham9 pushed a commit to arorasoham9/guac that referenced this pull request May 17, 2024
@huggingpixels @arorasoham9
Fix goreleaser flag deprecation warnings (guacsec#1814)
fc3329e 
Signed-off-by: Eszter Szucs-Matyas <eszter.szucs.matyas@gmail.com>
Signed-off-by: Soham Arora <arorasoham9@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumjjb lumjjb lumjjb approved these changes

@pxp928 pxp928 pxp928 approved these changes

Assignees
No one assigned
Labels
needs-review Needs writer LGTM size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Goreleaser deprecation warnings in local build
3 participants
@huggingpixels @lumjjb @pxp928