Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ent] Add missing neighbor, node and path query #1815

Merged
merged 30 commits into from Apr 5, 2024
Merged

[Ent] Add missing neighbor, node and path query #1815

merged 30 commits into from Apr 5, 2024

Conversation

pxp928
Copy link
Collaborator

@pxp928 pxp928 commented Apr 5, 2024

Description of the PR

Add missing neighbor, node and path query

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If OpenAPI spec is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

pxp928 added 27 commits April 5, 2024 09:16
@pxp928
inital commit for querying by node ID
038591d 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
update query by node ID for ent
ac9c33b 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
add new globalID to determine the node type
794b308 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
add type to create globalIDs
3fe551b 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
update node to check nodeType
b40623e 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
implement nodes query for ent
37e7013 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
output globalID during query and implement artifact neighbors
21cff24 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
optimize nodes query
5d68626 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
optimize artifact neighbors query
f8491bd 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
add builder and license neighbors query
5f98db9 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
add pkgtype, pkgnamespace neighbor query
3548e11 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
add neighbors query for packageNames
5e96c2e 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
add package neighbor queries
813b188 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
add source neighbor query
c2a4b39 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
add vulnerability neighbor
b2ce61b 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
add certifyBad and certifygood neighbor query
1309989 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
add isDep neighbors query
e9e26e3 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
add hashEqual neighbors query
0dd9790 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
add hasMetadata neighbors query
b64b139 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
add neighbors query for occurs
f3884ef 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
add neighbors query for pkgEquals
9b598f4 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
add neighbors query for poc
d0e7387 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
add neighbors query for sbom
7267d44 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
add neighbors query for hasSourceAt, vulnEqual and vulnMetadata
3af260f 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
add path query for ent
29ac00f 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
remove on delete logic in ent for occurence and artifact
258a891 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
re-add build tag for backend tests
ec7669e 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
fix lint issue
54b9acf 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
fix arrango edge bug and sort output
76e32bf 
Signed-off-by: pxp928 <parth.psu@gmail.com>
mrizzi
mrizzi reviewed Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment about filtering certifications

pkg/assembler/backends/ent/backend/artifact.go Show resolved Hide resolved
@pxp928
add type filter for certifybad and certifygood
d7dab5b 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@kodiakhq kodiakhq bot merged commit 2180123 into guacsec:main Apr 5, 2024
8 checks passed
@pxp928 pxp928 deleted the ent-fix-missing-queries branch April 5, 2024 16:01
arorasoham9 pushed a commit to arorasoham9/guac that referenced this pull request May 17, 2024
@pxp928 @arorasoham9
[Ent] Add missing neighbor, node and path query (guacsec#1815)
1d68017 
* inital commit for querying by node ID

Signed-off-by: pxp928 <parth.psu@gmail.com>

* update query by node ID for ent

Signed-off-by: pxp928 <parth.psu@gmail.com>

* add new globalID to determine the node type

Signed-off-by: pxp928 <parth.psu@gmail.com>

* add type to create globalIDs

Signed-off-by: pxp928 <parth.psu@gmail.com>

* update node to check nodeType

Signed-off-by: pxp928 <parth.psu@gmail.com>

* implement nodes query for ent

Signed-off-by: pxp928 <parth.psu@gmail.com>

* output globalID during query and implement artifact neighbors

Signed-off-by: pxp928 <parth.psu@gmail.com>

* optimize nodes query

Signed-off-by: pxp928 <parth.psu@gmail.com>

* optimize artifact neighbors query

Signed-off-by: pxp928 <parth.psu@gmail.com>

* add builder and license neighbors query

Signed-off-by: pxp928 <parth.psu@gmail.com>

* add pkgtype, pkgnamespace neighbor query

Signed-off-by: pxp928 <parth.psu@gmail.com>

* add neighbors query for packageNames

Signed-off-by: pxp928 <parth.psu@gmail.com>

* add package neighbor queries

Signed-off-by: pxp928 <parth.psu@gmail.com>

* add source neighbor query

Signed-off-by: pxp928 <parth.psu@gmail.com>

* add vulnerability neighbor

Signed-off-by: pxp928 <parth.psu@gmail.com>

* add certifyBad and certifygood neighbor query

Signed-off-by: pxp928 <parth.psu@gmail.com>

* add isDep neighbors query

Signed-off-by: pxp928 <parth.psu@gmail.com>

* add hashEqual neighbors query

Signed-off-by: pxp928 <parth.psu@gmail.com>

* add hasMetadata neighbors query

Signed-off-by: pxp928 <parth.psu@gmail.com>

* add neighbors query for occurs

Signed-off-by: pxp928 <parth.psu@gmail.com>

* add neighbors query for pkgEquals

Signed-off-by: pxp928 <parth.psu@gmail.com>

* add neighbors query for poc

Signed-off-by: pxp928 <parth.psu@gmail.com>

* add neighbors query for sbom

Signed-off-by: pxp928 <parth.psu@gmail.com>

* add neighbors query for hasSourceAt, vulnEqual and vulnMetadata

Signed-off-by: pxp928 <parth.psu@gmail.com>

* add path query for ent

Signed-off-by: pxp928 <parth.psu@gmail.com>

* remove on delete logic in ent for occurence and artifact

Signed-off-by: pxp928 <parth.psu@gmail.com>

* re-add build tag for backend tests

Signed-off-by: pxp928 <parth.psu@gmail.com>

* fix lint issue

Signed-off-by: pxp928 <parth.psu@gmail.com>

* fix arrango edge bug and sort output

Signed-off-by: pxp928 <parth.psu@gmail.com>

* add type filter for certifybad and certifygood

Signed-off-by: pxp928 <parth.psu@gmail.com>

---------

Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: Soham Arora <arorasoham9@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrizzi mrizzi mrizzi left review comments

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@jeffmendoza jeffmendoza jeffmendoza approved these changes

@lumjjb lumjjb Awaiting requested review from lumjjb

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pxp928 @mihaimaruseac @jeffmendoza @mrizzi