-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include a more descriptive debugger for the collector and processor #1830
Conversation
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
bcd844f
to
7f8f50e
Compare
7f8f50e
to
99534fc
Compare
e9e5f87
to
7aaff71
Compare
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
c1fdece
to
9723786
Compare
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
9723786
to
0790379
Compare
@nathannaveen just need to fix up the e2e test! Thanks! |
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nathannaveen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with what I think this is doing, but I just want to double check:
- this is not adding a debugger per-se, just another logging key to the logging object
- There is some re-factoring so as to remove duplicate code between the colector and the certifier ?
This latter part is not exactly necessary but somewhat of a drive-by consequence of working on this prt of the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
|
…uacsec#1830) * Subscriber Child Logger Working Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com> * Added Tests and a Child Logger for Publish Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com> * Fixed tests Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com> * add missing child logger to collector Signed-off-by: pxp928 <parth.psu@gmail.com> * add missing child logger to certifier Signed-off-by: pxp928 <parth.psu@gmail.com> --------- Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com> Signed-off-by: pxp928 <parth.psu@gmail.com> Co-authored-by: pxp928 <parth.psu@gmail.com> Signed-off-by: Soham Arora <arorasoham9@gmail.com>
Description of the PR
This PR incorporates a child logging system that records a unique
documentHash
. Since thedocumentHash
is being added to the child logger, the entire logging path will contain thedocumentHash
, greatly enhancing the comprehensibility of the log entries.This PR also includes tests for the child logger.
Log Outputs for the Processor
Log Outputs for the Collector
PR Checklist
-s
flag togit commit
.make generate
has been runmake generate
has been runcollectsub
protobuf has been changed,make proto
has been run