Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the Overview Diagram #1836

Merged
merged 1 commit into from Apr 15, 2024
Merged

Fix the Overview Diagram #1836

merged 1 commit into from Apr 15, 2024

Conversation

nathannaveen
Copy link
Contributor

Description of the PR

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If OpenAPI spec is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@nathannaveen
Fix the Overview Diagram
7cbcdec 
- The overview diagram had a red underline under `OpenSSF` because of a spelling error; this PR fixes that.
- There is also a PR in `guac_docs` for this: guacsec/guac-docs#123

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
mihaimaruseac
mihaimaruseac approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kodiakhq kodiakhq bot merged commit db16cdc into guacsec:main Apr 15, 2024
8 checks passed
nchelluri pushed a commit to nchelluri/guac that referenced this pull request Apr 16, 2024
@nathannaveen @nchelluri
Fix the Overview Diagram (guacsec#1836)
5b5a808 
- The overview diagram had a red underline under `OpenSSF` because of a spelling error; this PR fixes that.
- There is also a PR in `guac_docs` for this: guacsec/guac-docs#123

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
nchelluri pushed a commit to nchelluri/guac that referenced this pull request Apr 16, 2024
@nathannaveen @nchelluri
Fix the Overview Diagram (guacsec#1836)
cd12f1d 
- The overview diagram had a red underline under `OpenSSF` because of a spelling error; this PR fixes that.
- There is also a PR in `guac_docs` for this: guacsec/guac-docs#123

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
arorasoham9 pushed a commit to arorasoham9/guac that referenced this pull request May 17, 2024
@nathannaveen @arorasoham9
Fix the Overview Diagram (guacsec#1836)
b4e5f7f 
- The overview diagram had a red underline under `OpenSSF` because of a spelling error; this PR fixes that.
- There is also a PR in `guac_docs` for this: guacsec/guac-docs#123

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
Signed-off-by: Soham Arora <arorasoham9@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@pxp928 pxp928 pxp928 approved these changes

@jeffmendoza jeffmendoza Awaiting requested review from jeffmendoza

@lumjjb lumjjb Awaiting requested review from lumjjb

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nathannaveen @mihaimaruseac @pxp928