Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] implement fixes based on parsing and querying errors for CDX #1855

Merged
merged 2 commits into from Apr 23, 2024
Merged

[FIX] implement fixes based on parsing and querying errors for CDX #1855

merged 2 commits into from Apr 23, 2024

Conversation

pxp928
Copy link
Collaborator

@pxp928 pxp928 commented Apr 22, 2024

Description of the PR

fix #1854

Added missing types, fixed issues with CDX VEX ingestion, and fixed SPDX license error output.

Also, fix #1769

Removing https://github.com/guacsec/guac/blob/main/cmd/guacone/cmd/vulnerability.go#L431-L449 fixes this issue and does not affect the performance.

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If OpenAPI spec is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@pxp928
implement fixes based on parsing and querying errors
6743da4 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
add unit test for cdx vex use case
633dcae 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928 pxp928 requested a review from lumjjb April 22, 2024 01:38
@pxp928 pxp928 added the needs-review Needs writer LGTM label Apr 22, 2024
@kodiakhq kodiakhq bot merged commit d908792 into guacsec:main Apr 23, 2024
8 checks passed
arorasoham9 pushed a commit to arorasoham9/guac that referenced this pull request May 17, 2024
@pxp928 @arorasoham9
[FIX] implement fixes based on parsing and querying errors for CDX (g…
6a3bb84 
…uacsec#1855)

* implement fixes based on parsing and querying errors

Signed-off-by: pxp928 <parth.psu@gmail.com>

* add unit test for cdx vex use case

Signed-off-by: pxp928 <parth.psu@gmail.com>

---------

Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: Soham Arora <arorasoham9@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@lumjjb lumjjb lumjjb approved these changes

@jeffmendoza jeffmendoza Awaiting requested review from jeffmendoza jeffmendoza is a code owner

Assignees
No one assigned
Labels
needs-review Needs writer LGTM size/L
Projects
None yet
Milestone
No milestone
3 participants
@pxp928 @mihaimaruseac @lumjjb