Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add standalone postgres compose #1868

Merged
merged 1 commit into from Apr 28, 2024
Merged

Add standalone postgres compose #1868

merged 1 commit into from Apr 28, 2024

Conversation

jeffmendoza
Copy link
Collaborator

This compose will be used for new persistent setup instructions. It is a standalone file and doesn't need any additional files to be mounted into the containers. It is a complete single file (not multiple files merged) and doesn't contain anything unnecessary. Future docs will build upon it for adding additional collectors, etc.

Tested with release on my fork:
https://github.com/jeffmendoza/guac/releases/tag/v0.6.0-betajeff
https://github.com/jeffmendoza/guac/releases/download/v0.6.0-betajeff/guac-postgres-compose.yaml

Went through some demos and working well.

Description of the PR

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If OpenAPI spec is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@jeffmendoza
Copy link
Collaborator Author

Note: not messing with the existing container_files/ent.yaml file. The existing files used by the Makefile in integrations tests can stay. Those are multi-part to avoid duplication in test and dev, but we need a simplified one for users to use. We may end up consolidating somewhat in the future.

@jeffmendoza
Add standalone postgres compose
fe98c9a 
This compose will be used for new persistant setup instructions. It is a
standalone file and doesn't need any additional files to be mounted into the
containers. It is a complete single file (not multiple files merged) and
doesn't contain anything unecessary. Future docs will build upon it for adding
additional collectors, etc.

Signed-off-by: Jeff Mendoza <jlm@jlm.name>
@kodiakhq kodiakhq bot merged commit 90d95a5 into guacsec:main Apr 28, 2024
8 checks passed
arorasoham9 pushed a commit to arorasoham9/guac that referenced this pull request May 17, 2024
@jeffmendoza @arorasoham9
Add standalone postgres compose (guacsec#1868)
8a5ab2d 
This compose will be used for new persistant setup instructions. It is a
standalone file and doesn't need any additional files to be mounted into the
containers. It is a complete single file (not multiple files merged) and
doesn't contain anything unecessary. Future docs will build upon it for adding
additional collectors, etc.

Signed-off-by: Jeff Mendoza <jlm@jlm.name>
Signed-off-by: Soham Arora <arorasoham9@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@pxp928 pxp928 pxp928 approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jeffmendoza @mihaimaruseac @pxp928