Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose certifier and deps.dev batch size and add optional latency (defaults to none) #1967

Merged
merged 5 commits into from
Jun 14, 2024

Conversation

pxp928
Copy link
Collaborator

@pxp928 pxp928 commented Jun 14, 2024

Description of the PR

Expose certifier and deps.dev batch size and add optional latency (defaults to none)

// set the batch size for the package pagination query
set.Int("certifier-batch-size", 60000, "sets the batch size for pagination query for the certifier")
// add artificial latency to throttle the certifier
set.String("certifier-latency", "", "sets artificial latency on the certifier. Defaults to empty string (not enabled) but can set m, h, s...etc")

// deps.dev
// add artificial latency to throttle deps.dev
set.String("deps-dev-latency", "", "sets artificial latency on the deps.dev collector. Defaults to empty string (not enabled) but can set m, h, s...etc")

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If GraphQL schema is changed, GraphQL client updates/additions have been made
  • If OpenAPI spec is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Copy link
Collaborator

@jeffmendoza jeffmendoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Keep in mind that the main demo and postgres compose setups don't use guac.yaml now. So if you want to have non-default options there you should edit those composes:
https://github.com/guacsec/guac/releases/latest/download/guac-demo-compose.yaml
https://github.com/guacsec/guac/blob/main/container_files/guac-postgres-compose.yaml

@kodiakhq kodiakhq bot merged commit ff4c8af into guacsec:main Jun 14, 2024
8 checks passed
@pxp928 pxp928 deleted the collectors-expose-flags branch June 14, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants