Add document guesser foundations #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brandon Lum <lumjjb@gmail.com>
|
o wait, adding some simple tests |
Signed-off-by: Brandon Lum <lumjjb@gmail.com>
|
technically, a bit of an edge case where if a document is too small, it may match multiple formats, but don't think that would be an issue. |
This was referenced Aug 25, 2022
mihaimaruseac
approved these changes
Aug 25, 2022
| return processor.FormatJSON | ||
| } | ||
| return processor.FormatUnknown | ||
| } |
There was a problem hiding this comment.
I think we should call the RegisterDocumentFormatGuesser function here in init, so it always gets registered when this module is imported?
Signed-off-by: Brandon Lum <lumjjb@gmail.com>
pxp928
reviewed
Aug 25, 2022
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package guesser |
There was a problem hiding this comment.
minior nit: Do we want to break out the the implementation into a separate package
There was a problem hiding this comment.
I was doing that, then i felt like i was writing java in the 90s, then i reverted it back lol... maybe a follow up PR
1 task
mrizzi
added a commit
to mrizzi/guac
that referenced
this pull request
Nov 16, 2023
* Fix RH CSAF Parser Signed-off-by: mrizzi <mrizzi@redhat.com> * CSAF Parser: fix double ingestion Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #26
Signed-off-by: Brandon Lum lumjjb@gmail.com