Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add usecase where the name is just the image name in cdx/spdx sbom created via syft #388

Merged
merged 2 commits into from
Feb 1, 2023

Conversation

pxp928
Copy link
Collaborator

@pxp928 pxp928 commented Jan 31, 2023

Signed-off-by: pxp928 parth.psu@gmail.com

  1. Handle usecase where the "name" in CDX SBOM is just the image name (no registry or repo).
  2. Update SPDX for single document name usecase
  3. Update SPDX to partially match OCI spec until tool is SPDX element/relationships should be defined for the container image being described anchore/syft#1241 is resolved.
  4. Updated setup.md with changes to query for SPDX

fixes #387

…syft

Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
Copy link
Collaborator Author

pxp928 commented Jan 31, 2023

This PR is will merge into heuristic-dev branch until use cases are captured.

@mlieberman85
Copy link
Collaborator

Handle usecase where the "name" in CDX SBOM is just the image name (no registry or repo).

Just a note that this isn't really a use case, it's just a part of both SPDX and CDX spec. It just so happens some tools include the repo, but nothing in the spec states that it must include repo. I would recommend we don't rely on the name at all too much.

@pxp928 pxp928 merged commit 2f61b0e into guacsec:heuristic-dev Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants