make startedOn and finishedOn optional fields for hasSLSA #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pxp928 <parth.psu@gmail.com>
mihaimaruseac
approved these changes
May 19, 2023
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
jeffmendoza
reviewed
May 19, 2023
jeffmendoza
reviewed
May 19, 2023
Signed-off-by: Jeff Mendoza <jlm@jlm.name>
jeffmendoza
approved these changes
May 19, 2023
sunnyyip
pushed a commit
to sunnyyip/guac
that referenced
this pull request
May 24, 2023
* make startedOn and finishedOn optional fields for hasSLSA Signed-off-by: pxp928 <parth.psu@gmail.com> * fix trailing space and unit tests Signed-off-by: pxp928 <parth.psu@gmail.com> * remove start and end time on one test for test data ingestion Signed-off-by: pxp928 <parth.psu@gmail.com> * Change to leave time blank if not provided on input. Signed-off-by: Jeff Mendoza <jlm@jlm.name> --------- Signed-off-by: pxp928 <parth.psu@gmail.com> Signed-off-by: Jeff Mendoza <jlm@jlm.name> Co-authored-by: Jeff Mendoza <jlm@jlm.name>
mlieberman85
pushed a commit
to mlieberman85/artifact-ff
that referenced
this pull request
Jul 5, 2023
* make startedOn and finishedOn optional fields for hasSLSA Signed-off-by: pxp928 <parth.psu@gmail.com> * fix trailing space and unit tests Signed-off-by: pxp928 <parth.psu@gmail.com> * remove start and end time on one test for test data ingestion Signed-off-by: pxp928 <parth.psu@gmail.com> * Change to leave time blank if not provided on input. Signed-off-by: Jeff Mendoza <jlm@jlm.name> --------- Signed-off-by: pxp928 <parth.psu@gmail.com> Signed-off-by: Jeff Mendoza <jlm@jlm.name> Co-authored-by: Jeff Mendoza <jlm@jlm.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the PR
make startedOn and finishedOn optional fields for hasSLSA
PR Checklist
-sflag togit commit.make generatehas been runcollectsubprotobuf has been changed,make protohas been run