-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ingestion from guacone parallel #884
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffmendoza
force-pushed
the
ingest-parallel
branch
from
May 23, 2023 17:45
14bb12c
to
1ec2d9c
Compare
mihaimaruseac
approved these changes
May 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but let's wait until after v0.1
lumjjb
approved these changes
May 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Jeff Mendoza <jlm@jlm.name>
jeffmendoza
force-pushed
the
ingest-parallel
branch
from
May 31, 2023 17:19
1ec2d9c
to
9cd3ce2
Compare
rmetzman
pushed a commit
to rmetzman/guac
that referenced
this pull request
Jun 5, 2023
Signed-off-by: Jeff Mendoza <jlm@jlm.name>
rmetzman
pushed a commit
to rmetzman/guac
that referenced
this pull request
Jun 5, 2023
Signed-off-by: Jeff Mendoza <jlm@jlm.name> Signed-off-by: Rebecca Metzman <rmetzman@google.com>
rmetzman
pushed a commit
to rmetzman/guac
that referenced
this pull request
Jun 8, 2023
Signed-off-by: Jeff Mendoza <jlm@jlm.name> Signed-off-by: Rebecca Metzman <rmetzman@google.com>
rmetzman
pushed a commit
to rmetzman/guac
that referenced
this pull request
Jun 8, 2023
Signed-off-by: Jeff Mendoza <jlm@jlm.name> Signed-off-by: Rebecca Metzman <rmetzman@google.com>
rmetzman
pushed a commit
to rmetzman/guac
that referenced
this pull request
Jun 8, 2023
Signed-off-by: Jeff Mendoza <jlm@jlm.name> Signed-off-by: Rebecca Metzman <rmetzman@google.com>
mlieberman85
pushed a commit
to mlieberman85/artifact-ff
that referenced
this pull request
Jul 5, 2023
Signed-off-by: Jeff Mendoza <jlm@jlm.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the PR
This should speed up
guacone collect files
quite a bit when running with some network latency between guacone and the gql server.PR Checklist
-s
flag togit commit
.make generate
has been runcollectsub
protobuf has been changed,make proto
has been run