Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add guac links to past presentations #885

Merged
merged 2 commits into from May 24, 2023
Merged

add guac links to past presentations #885

merged 2 commits into from May 24, 2023

Conversation

lumjjb
Copy link
Contributor

@lumjjb lumjjb commented May 23, 2023

Description of the PR

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

Signed-off-by: Brandon Lum <lumjjb@gmail.com>
README.md Show resolved Hide resolved
Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we link to the YouTube versions of the talks?

Signed-off-by: Brandon Lum <lumjjb@gmail.com>
@lumjjb
Copy link
Contributor Author

lumjjb commented May 24, 2023

i updated to point to youtube for one of them since OSS NA hasnt uploaded yet

@kodiakhq kodiakhq bot merged commit 1e89b83 into main May 24, 2023
8 checks passed
@kodiakhq kodiakhq bot deleted the add-links branch May 24, 2023 11:04
rmetzman pushed a commit to rmetzman/guac that referenced this pull request Jun 5, 2023
* add guac links to past presentations

Signed-off-by: Brandon Lum <lumjjb@gmail.com>

* address comments

Signed-off-by: Brandon Lum <lumjjb@gmail.com>

---------

Signed-off-by: Brandon Lum <lumjjb@gmail.com>
rmetzman pushed a commit to rmetzman/guac that referenced this pull request Jun 5, 2023
* add guac links to past presentations

Signed-off-by: Brandon Lum <lumjjb@gmail.com>

* address comments

Signed-off-by: Brandon Lum <lumjjb@gmail.com>

---------

Signed-off-by: Brandon Lum <lumjjb@gmail.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
rmetzman pushed a commit to rmetzman/guac that referenced this pull request Jun 8, 2023
* add guac links to past presentations

Signed-off-by: Brandon Lum <lumjjb@gmail.com>

* address comments

Signed-off-by: Brandon Lum <lumjjb@gmail.com>

---------

Signed-off-by: Brandon Lum <lumjjb@gmail.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
mlieberman85 pushed a commit to mlieberman85/artifact-ff that referenced this pull request Jul 5, 2023
* add guac links to past presentations

Signed-off-by: Brandon Lum <lumjjb@gmail.com>

* address comments

Signed-off-by: Brandon Lum <lumjjb@gmail.com>

---------

Signed-off-by: Brandon Lum <lumjjb@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants