Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use POSIX compliant way to redirect file descriptors in Makefile #919

Merged
merged 1 commit into from Jun 6, 2023
Merged

use POSIX compliant way to redirect file descriptors in Makefile #919

merged 1 commit into from Jun 6, 2023

Conversation

sunnyyip
Copy link
Collaborator

@sunnyyip sunnyyip commented Jun 6, 2023

Description of the PR

Use POSIX compliant syntax to redirect file descriptors.
The '&>' syntax is bash specific and may not work in other shells.

Fixes #909

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@sunnyyip
use POSIX compliant way to redirect file descriptor
1447cae 
Signed-off-by: Sunny Yip <sunny@kusari.dev>
@sunnyyip sunnyyip requested a review from lumjjb June 6, 2023 18:47
@kodiakhq kodiakhq bot merged commit 2dff95e into guacsec:main Jun 6, 2023
8 checks passed
@sunnyyip sunnyyip deleted the fix-makefile branch June 9, 2023 16:09
rmetzman pushed a commit to rmetzman/guac that referenced this pull request Jun 21, 2023
@sunnyyip
use POSIX compliant way to redirect file descriptor (guacsec#919)
e8ca043 
Signed-off-by: Sunny Yip <sunny@kusari.dev>
mlieberman85 pushed a commit to mlieberman85/artifact-ff that referenced this pull request Jul 5, 2023
@sunnyyip @mlieberman85
use POSIX compliant way to redirect file descriptor (guacsec#919)
2f49010 
Signed-off-by: Sunny Yip <sunny@kusari.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffmendoza jeffmendoza jeffmendoza approved these changes

@lumjjb lumjjb lumjjb approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docker tool check in Makefile fails when running "make container"
3 participants
@sunnyyip @jeffmendoza @lumjjb