Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix time equal check bug in certifyVuln and ensure that other match in the inmem database #923

Merged
merged 1 commit into from Jun 7, 2023

Conversation

pxp928
Copy link
Collaborator

@pxp928 pxp928 commented Jun 7, 2023

Description of the PR

fix time equal check bug in certifyVuln and ensure that other match in the inmem database

fixes #921

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

…n the inmem database

Signed-off-by: pxp928 <parth.psu@gmail.com>
Copy link
Collaborator

@mlieberman85 mlieberman85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot merged commit d46cbbd into guacsec:main Jun 7, 2023
8 checks passed
@pxp928 pxp928 deleted the issue-921 branch June 7, 2023 15:36
rmetzman pushed a commit to rmetzman/guac that referenced this pull request Jun 21, 2023
…n the inmem database (guacsec#923)

Signed-off-by: pxp928 <parth.psu@gmail.com>
mlieberman85 pushed a commit to mlieberman85/artifact-ff that referenced this pull request Jul 5, 2023
…n the inmem database (guacsec#923)

Signed-off-by: pxp928 <parth.psu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] certifyVuln falsely filtering out when timeScanned match
3 participants